-
Notifications
You must be signed in to change notification settings - Fork 2.5k
fix: add /evals page to sitemap generation #7102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The /evals page is a dynamic route and wasn't being included in the sitemap automatically. Added it explicitly to the additionalPaths function to ensure it's included in the generated sitemap with proper priority (0.8) and change frequency (monthly).
|
🚀 Preview deployed! Your changes have been deployed to Vercel: Preview URL: https://roo-code-website-4c1mmbu31-roo-code.vercel.app This preview will be updated automatically when you push new commits to this PR. |
| loc: '/evals', | ||
| changefreq: 'monthly', | ||
| priority: 0.8, | ||
| lastmod: new Date().toISOString(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider conditionally setting the lastmod value based on config.autoLastmod (as done in the transform function) to maintain consistency if auto-lastmod is disabled.
| lastmod: new Date().toISOString(), | |
| lastmod: config.autoLastmod ? new Date().toISOString() : undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I've reviewed the changes and have some suggestions for improvement.
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
* main: (70 commits) fix: use native Ollama API instead of OpenAI compatibility layer (RooCodeInc#7137) feat: add support for OpenAI gpt-5-chat-latest model (RooCodeInc#7058) Make enhance with task history default to true (RooCodeInc#7140) Bump cloud version to 0.16.0 (RooCodeInc#7135) Release: v1.51.0 (RooCodeInc#7130) Add an API for resuming tasks by ID (RooCodeInc#7122) Add support for task page event population (RooCodeInc#7117) fix: add type check before calling .match() on diffItem.content (RooCodeInc#6905) (RooCodeInc#6906) Fix: Enable save button for provider dropdown and checkbox changes (RooCodeInc#7113) fix: Use cline.cwd as primary source for workspace path in codebaseSearchTool (RooCodeInc#6902) Hotfix multiple folder workspace checkpoint (RooCodeInc#6903) fix: prevent XML entity decoding in diff tools (RooCodeInc#7107) (RooCodeInc#7108) Refactor task execution system: improve call stack management (RooCodeInc#7035) Changeset version bump (RooCodeInc#7104) feat(web): fill missing SEO-related values (RooCodeInc#7096) Update contributors list (RooCodeInc#6883) Release v3.25.15 (RooCodeInc#7103) fix: add /evals page to sitemap generation (RooCodeInc#7102) feat: implement sitemap generation in TypeScript and remove XML file (RooCodeInc#6206) fix: reset condensing state when switching tasks (RooCodeInc#6922) ...
Description
The
/evalspage was missing from the generated sitemap because it's a dynamic route that isn't automatically discovered by next-sitemap.Changes
apps/web-roo-code/next-sitemap.config.cjsto explicitly add the/evalspage in theadditionalPathsfunction/evalspage to match the configuration in the transform functionTesting
pnpm buildinapps/web-roo-code/evalsis now included in the generatedpublic/sitemap.xml/(homepage) - priority 1.0/enterprise- priority 0.8/evals- priority 0.8 ✅ (now fixed)/privacy- priority 0.5/terms- priority 0.5Related Issues
Follow-up fix to PR #6206 which implemented next-sitemap but missed the dynamic
/evalsroute.Important
Add
/evalspage to sitemap generation innext-sitemap.config.cjswith priority 0.8 and monthly change frequency.next-sitemap.config.cjsto include/evalsinadditionalPaths./evalspriority to 0.8 and change frequency to monthly./evalsinclusion inpublic/sitemap.xmlafter runningpnpm build.This description was created by
for b399af9. You can customize this summary. It will automatically update as commits are pushed.